Ultimately, it's any shot that calls attention to itself and pulls you out of the story. Film is primarily a visual medium so you want to be interesting and all the tricks can add to the mood or structure of the film. It's when a filmaker chooses a shot to say "Look at my cool shot" that it's a problem. With all that having been said, my biggest pet peeve is...cg imagery. It ain't really a cinematography trick but I get green screen out, too many blockbuster movies that look like a video game. Notable recent exception, Sin City, it captures mood, doesn't detract from it.